Skip to content

Fix Minor Windows Issues #1438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 7 commits into from
Closed

Fix Minor Windows Issues #1438

wants to merge 7 commits into from

Conversation

TimPansino
Copy link
Contributor

@TimPansino TimPansino commented Jul 31, 2025 •
edited
Loading

Overview

  • Fix several minor issues with the agent for Windows support.
  • Should be reviewed by commit.

@TimPansino TimPansino force-pushed the fix-windows-issues branch from a389753 to 6093c27 Compare July 31, 2025 17:43
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 31, 2025 •
edited
Loading

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ ACTION actionlint 6 0 0 0.76s
✅ MARKDOWN markdownlint 7 0 0 0 1.04s
✅ MARKDOWN markdown-link-check 7 0 0 26.82s
✅ PYTHON ruff 922 0 0 0 1.03s
✅ PYTHON ruff-format 922 0 0 0 0.29s
✅ YAML prettier 13 0 0 0 1.28s
✅ YAML v8r 13 0 0 4.59s
✅ YAML yamllint 13 0 0 0.63s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

@mergify mergify bot added the tests-failing Tests failing in CI. label Jul 31, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jul 31, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 78.26087% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.38%. Comparing base (4073419) to head (0baa6f1).

Files with missing lines Patch % Lines
newrelic/core/agent_control_health.py 77.77% 8 Missing and 2 partials ⚠️
Additional details and impacted files 
@@                 Coverage Diff                 @@
##           develop-windows    #1438      +/-   ##
===================================================
- Coverage            81.39%   81.38%   -0.02%     
===================================================
  Files                  208      208              
  Lines                23563    23583      +20     
  Branches              3716     3722       +6     
===================================================
+ Hits                 19179    19192      +13     
- Misses                3129     3134       +5     
- Partials              1255     1257       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mergify mergify bot removed the tests-failing Tests failing in CI. label Aug 4, 2025
@TimPansino TimPansino closed this Aug 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TimPansino @codecov-commenter